Introduce User::PermissionsOverview
and use it to render permissions to admins
#11188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the problem
hcb/app/models/organizer_position.rb
Lines 57 to 75 in 69b9a85
WITH RECURSIVE
querieshcb/app/models/event.rb
Lines 123 to 136 in da06bad
OrganizerPosition
records.OrganizerPosition.role_at_least?
quite a bit, both directly and indirectly via helpers and Pundit policy objects. Given its current structure it isn't particularly amenable to cacheing (e.g. we run a different query for eachrole
we're asking about and the information we retrieve doesn't tell us whether the user has greater access than that role).Describe your changes
To improve things a little I'd like to add
User::PermissionsOverview
class that has logic to retrieve the complete graph of events the user is associated with (both the event ancestors and descendants) and figure out whatrole
they should have for each of them based on the existingOrganizerPosition.role_at_least?
logicOrganizerPosition.role_at_least?
For the time being I see this as a useful auditing and debugging tool, and it gives us a good starting point should we decide to cache all of a user's permissions.