[Announcement] Cancel monthly announcements with no data #11257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the problem
Right now, monthly announcements are enabled for a lot of transparent organizations, including some that may not have any activity. We don't want to send out all these monthly announcements with empty data, like if the organization has no donations.
Describe your changes
Any announcements that are still template drafts at the end of the month will not be published. At the 7 day mark, monthly announcements that have data in all of their blocks will be promoted to drafts, which will allow them to be sent. All other monthly announcements will be left as template drafts and a notification will be sent out to managers that if they do not edit the announcement, it will not be sent out. This is also displayed in a callout on the announcements page.