Skip to content

[Loops] Clean-up Faraday usage (take 2) #11292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 20, 2025
Merged

[Loops] Clean-up Faraday usage (take 2) #11292

merged 2 commits into from
Aug 20, 2025

Conversation

davidcornu
Copy link
Member

Summary of the problem

  1. In Make sure unsuccessful HTTP calls with Faraday result in exceptions #11237 I centralized SyncWithLoops's Faraday instance and added the :raise_errors middleware so we'd get exceptions when things went wrong
  2. I subsequently noticed this was causing issues in production so undid my changes in Restore changes to Loops client #11291
  3. After digging a bit more I realized that 404s were to be expected from this endpoint and that this was previously handled by return nil if resp.body.strip == "[]"
    https://loops.so/docs/api-reference/find-contact
    CleanShot 2025-08-11 at 11 39 41@2x

Describe your changes

Added a rescue block for Faraday::ResourceNotFound that just returns nil

@davidcornu davidcornu requested review from a team as code owners August 11, 2025 15:42
@davidcornu
Copy link
Member Author

Approved via Slack: https://hackclub.slack.com/archives/C047Y01MHJQ/p1755638613925669?thread_ts=1755636753.938879&cid=C047Y01MHJQ

@davidcornu davidcornu added this pull request to the merge queue Aug 20, 2025
Merged via the queue into main with commit bcb9512 Aug 20, 2025
13 checks passed
@davidcornu davidcornu deleted the david/push-qpulplmpymys branch August 20, 2025 13:36
davidcornu added a commit that referenced this pull request Aug 20, 2025
@davidcornu
Revert "[Loops] Clean-up Faraday usage (take 2) (#11292)"
336253a 
This reverts commit bcb9512.
@davidcornu davidcornu mentioned this pull request Aug 20, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 20, 2025
@davidcornu
Revert "[Loops] Clean-up Faraday usage (take 2)" (#11376)
b108c44 
Reverts #11292

This introduced new issues in production:
https://hackclub.slack.com/archives/C096P73LEMT/p1755697898360079
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davidcornu