Add more nuanced premium perk ineligible tooltips #11342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampoder
reviewed
Aug 18, 2025
| <% if (!@perks_available || [email protected]_by_teenagers? || @event.users.count { |user| user.teenager? && user.active? } < 10) %> | ||
| <div class="tooltipped tooltipped--w inline-block" aria-label="Must have at least 10 active teenagers"> | ||
| <% if !@perks_available %> | ||
| <div class="tooltipped tooltipped--w inline-block" aria-label="User must be manager and org must not be HQ-affiliated"> |
There was a problem hiding this comment.
Suggested change
| <div class="tooltipped tooltipped--w inline-block" aria-label="User must be manager and org must not be HQ-affiliated"> | |
| <div class="tooltipped tooltipped--w inline-block" aria-label="User must be manager and organization must not be HQ-affiliated"> |
Also - we should split these into two scenarios. "HQ-affiliated" isn't something every user will be familiar with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
different tooltips depending on reason org is ineligible for premium (manager perms, hq-affil, teen tag, matus)