Skip to content

opt: improved analyzer collect approach #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

labbbirder
Copy link
Contributor

This is an addition to PR #168 , having a significant improvement.

Tested on all known editor packages:

  • Visual Studio Editor
  • Visual Studio Code Editor
  • JetBrains Rider Editor

@handzlikchris
Copy link
Owner

Thanks - now with parsing inolved I think it'd be good to extract getting analyzers to separate method and wrap it in error handling. It's in quite critical part and I wouldn't want it to stop compiling due to some project-file parse error

@handzlikchris handzlikchris self-requested a review May 12, 2025 07:45
Copy link
Owner

@handzlikchris handzlikchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - now with parsing inolved I think it'd be good to extract getting analyzers to separate method and wrap it in error handling. It's in quite critical part and I wouldn't want it to stop compiling due to some project-file parse error

@labbbirder labbbirder requested a review from handzlikchris May 12, 2025 08:36
@labbbirder
Copy link
Contributor Author

Thanks - now with parsing inolved I think it'd be good to extract getting analyzers to separate method and wrap it in error handling. It's in quite critical part and I wouldn't want it to stop compiling due to some project-file parse error

Right. That's reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants