WIP: major refactor for q as a module #350
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors q into a module with major version updates and introduces several new test suites, updated dependencies, and CI/CD workflow configurations.
- Added new tests for delimiter behavior, benchmarking, and query analysis
- Updated package metadata, versioning, and documentation
- Revamped GitHub workflows and removed outdated scripts
Reviewed Changes
Copilot reviewed 52 out of 52 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/DelimiterTests.py | New tests for delimiter handling (note spelling discrepancies) |
| test/BenchmarkTests.py | New benchmark tests with a corrected assertion and performance tests |
| test/AnalysisTests.py | New analysis tests ensuring proper query output analysis |
| test-requirements.txt | Updated pytest and added xdist dependency |
| setup.py | Updated package name, version sourcing, and configuration |
| run-tests.sh | Removed outdated test runner script |
| qtextasdata/*.py (utilities, logging, etc.) | New module implementations and exception handling |
| pyoxidizer.bzl | Removed outdated build configuration |
| bump-version.py | Added version bumping script with semantic versioning logic |
| README.markdown & CHANGELOG.md | Updated documentation and changelog for new release |
| .github/workflows/* | New CI/CD configurations for testing, publishing, and docs |
| .python-version | Added new python version marker (refactor-q) |
|
|
||
| class DelimiterTests(AbstractQTestCase): | ||
|
|
||
| def test_delimition_mistake_with_header(self): |
There was a problem hiding this comment.
[nitpick] The word 'delimition' appears to be misspelled; consider correcting it to 'delimiter' for clarity.
Suggested change
| def test_delimition_mistake_with_header(self): | |
| def test_delimiter_mistake_with_header(self): |
Copilot uses AI. Check for mistakes.
| self.assertEqual(r, 0) | ||
| # Create file cache as part of preparation | ||
| r, o, e = run_command(Q_EXECUTABLE + ' -C readwrite -d , "select count(*) from %s"' % filename) | ||
| self.asserEqual(r, 0) |
There was a problem hiding this comment.
There is a typo in the assertion method name; it should be 'assertEqual' instead of 'asserEqual'.
Suggested change
| self.asserEqual(r, 0) | |
| self.assertEqual(r, 0) |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(github Actions changes are still in progress)