fwserver: add ListResource method
#1153
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbasata
force-pushed
the
add-list-to-fwserver-part-iii
branch
from
4640688 to
b7fea91
Compare
bbasata
force-pushed
the
add-list-to-fwserver-part-ii
branch
from
1da956e to
70aac24
Compare
bbasata
force-pushed
the
add-list-to-fwserver-part-iii
branch
from
b7fea91 to
b941cae
Compare
bbasata
force-pushed
the
add-list-to-fwserver-part-ii
branch
from
70aac24 to
d6776b3
Compare
bbasata
force-pushed
the
add-list-to-fwserver-part-iii
branch
from
b941cae to
73392ce
Compare
bbasata
force-pushed
the
add-list-to-fwserver-part-ii
branch
5 times, most recently
from
be455ea to
7691bb8
Compare
bbasata
force-pushed
the
add-list-to-fwserver-part-iii
branch
2 times, most recently
from
49f3d27 to
53f6a7c
Compare
bbasata
force-pushed
the
add-list-to-fwserver-part-iii
branch
from
84bb222 to
78fc148
Compare
bbasata
commented
Jun 3, 2025
| // processListResult validates the content of a list.ListResult and returns a | ||
| // ListResult | ||
| func processListResult(req list.ListRequest, result list.ListResult) ListResult { | ||
| if result.Identity == nil { |
| } | ||
| } | ||
|
|
||
| if req.IncludeResource && result.Resource == nil { |
| type ListResourceStream struct { | ||
| // Results is a function that emits ListResult values via its push | ||
| // function argument. | ||
| Results iter.Seq[ListResult] |
There was a problem hiding this comment.
💭 A follow-up enhancement: what if a (List) Resource uses its data model instead of ListResult here? and Framework uses fwschemadata to transform the data model into a ListResult Terraform value?
Suggested change
| Results iter.Seq[ListResult] | |
| Results iter.Seq[any-ish] |
There was a problem hiding this comment.
what if a (List) Resource uses its data model
... and also, what if a List Resource "encapsulates" an SDKv2 managed resource, so it has no existing data model? is this still useful?
|
Closing in favor of #1157. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To merge after #1152. This pull request adds a
ListResourceimplementation to the protocol-independent framework server.Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.