memoize redundant references #37191
Closed
memoize redundant references #37191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsa0x
added
the
no-changelog-needed
dsa0x
commented
Jun 2, 2025
Comment on lines
-278
to
-285
| // The reference set we are given has not been de-duped, and so there can | ||
| // be redundant requests in it for two reasons: | ||
| // - The same item is referenced multiple times | ||
| // - Both an item and that item's container are separately referenced. | ||
| // We will still visit every reference here and ask our data source for | ||
| // it, since that allows us to gather a full set of any errors and | ||
| // warnings, but once we've gathered all the data we'll then skip anything | ||
| // that's redundant in the process of populating our values map. |
There was a problem hiding this comment.
I think this comment may no longer be relevant to the current implementation.
Today, we have the .StaticValidReferences call that validates all the static references, and the main loop here just retrieves things from the data source, and that retrieval is done solely based on the reference's subject, not the entire traversal.
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Target Release
1.13.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry