Removing the date suffix for TFE github tokens #1091
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vercel Previews Deployed
|
vmacdougal-hc
approved these changes
Oct 9, 2025
vmacdougal-hc
approved these changes
Oct 9, 2025
RubenSandwich
requested changes
Oct 10, 2025
There was a problem hiding this comment.
@jkerry can you also rotate/create this key in the internal copy of this repo: https://github.com/hashicorp/web-unified-docs-internal?
As that is often used by the TFE team for embargoed content, and when this PR syncs if those tokens don't exist/arn't rotated then this PR will break the builds in that repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the TFE GitHub credential variable in GitHub actions to target one that has been recently rotated. This change updates the name of the variable to a date-generic variant so future credential rotations are as simple as updating that variable value in the actions secrets.