Skip to content

Allow build 3.0.0, min language 3.8.0, generate new style, reformat #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

davidmorgan
Copy link

For #394

There is no change needed to allow the new build 3.0.0 as the changes relate to using the analyzer, which graphql_codegen does not.

But it does require updating to build_test 3.0.0 which needs some small changes to tests.

And, it causes json_serializable 6.10.0 to be used, which required language version 3.8.0, so increase the minimum language version. This triggers a huge reformat(!) because the dartfmt style changes at language version 3.7.0. The second commit is just the reformat from dart format ..

@davidmorgan
Copy link
Author

Oh ... this doesn't work yet due to the effect of the reformat on golden file compares ... will see if I can figure out a good fix.

@davidmorgan
Copy link
Author

Changing the generated output to also be 3.8.0 style seems to have done the trick.

That should be what people want, since the language version of the package is now 3.8.0 so they should be on that style.

@davidmorgan davidmorgan changed the title Allow build 3 Allow build 3.0.0, min language 3.8.0, generate new style, reformat Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant