Improved github CI #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed CI tests weren't running even after landing .github/workflows/test.yml to main --> checked out our YAML at https://rhysd.github.io/actionlint/ and fixed a couple issues.
I also set things up so that the integration tests just spin up a temporary example MCP app, so we don't run into issues trying to test against a shared staging app. Much better!
Tests stdio / sse / http locally, and then tests stdio (one-off dyno) + the deployed web server (default http) on the deployed web app.
Took an embarrasingly long time to realize that I was getting non-deterministic errors because of the lack of a WEB_CONCURRENCY config var in the CI-deployed app. Pro-tip: read past-you's documentation, sometimes it includes useful tips 🫠.
https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00002FuUHtYAN/view