-
Notifications
You must be signed in to change notification settings - Fork 10
chore: Minor update to adjust naming and clean up wrapping #1706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
9c9bb67
to
10e3d14
Compare
10e3d14
to
2c47a33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I like the shorter and improved naming. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build is failing because of ExtendedMerkleTreeVerificationSessionV0680
usage in ExtendedMerkleTreeVerificationSessionV0680Test
Merge error, |
2c47a33
to
2eec807
Compare
* Renamed sessions to remove redundant "Verification" and "Block" terms. * Renamed session factory to include criteria in the class name instead of redundant words * Added some message variables and cleaned up excessive wrapping * Removed exception-as-goto usage in VerificationServicePlugin; replaced with if/else usage. * Moved failure notification to a new method for consistency. * Applied spotless which further adjusted wrapping Signed-off-by: Joseph S <[email protected]>
2eec807
to
7bdc226
Compare
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #1706 +/- ##
============================================
+ Coverage 79.97% 80.04% +0.06%
Complexity 1144 1144
============================================
Files 125 125
Lines 5333 5331 -2
Branches 566 567 +1
============================================
+ Hits 4265 4267 +2
+ Misses 817 811 -6
- Partials 251 253 +2
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Reviewer Notes
This PR is a vehicle for clearer discussion of some recommended changes that we were struggling to discuss in a previous PR.