fix(rust) ensure brackets are balanced within attributes #4237
+62
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yang062
approved these changes
Apr 9, 2025
joshgoebel
reviewed
Apr 23, 2025
…ensure-bracket-balance
ewwwin
force-pushed
the
fix/rust-attribute-ensure-bracket-balance
branch
from
31f7444 to
84bcd12
Compare
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +80 B View Changes
|
…ensure-bracket-balance
Yang062
approved these changes
Jun 7, 2025
Yang062
approved these changes
Jun 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4032.
Changes
Rust attributes can contain nested brackets, braces, and parentheses. This PR adds sub-modes for these nested delimiter groups, ensuring that attribute matches ends only when nested square brackets and other delimiters are balanced.
Syntax reference: The Rust Reference: Attributes. (The actual set of recognized bracket types is derived from DelimTokenTree which is defined in Macros).
Checklist
CHANGES.md