Skip to content

Conversation

peterkuiper
Copy link

Fixes #53

@himelbrand
Copy link
Owner

Thanks a lot for your contribution!
Please make it possible to use one or the other... depending on need

@jarod-legault
Copy link

jarod-legault commented May 30, 2024

@himelbrand I'm not sure why there should be an option of different types for iconStyle. If you look at IconProps from react-native-vector-icons/Icon, it extends TextProps from react-native, which in turn uses TextStyle for the style prop. It seems like this PR is correct and will eliminate Typescript errors for users, specifically when attempting to set the color of the icons. But maybe I am misunderstanding your comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] - ViewStyle does not allow color

3 participants