Skip to content

fix: use burn_block_time in 2.x blocks and block_time after 3.x #2314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

rafaelcr
Copy link
Collaborator

@rafaelcr rafaelcr commented Jul 3, 2025

Stacks core now sends block_time for Nakamoto blocks after stacks-network/stacks-core#5113 was merged, and null for Stacks 2.x blocks.

This PR changes our DB code so we always try to use the block_time but default to burn_block_time for 2.x blocks.

Copy link

github-actions bot commented Jul 3, 2025

Vercel deployment URL: https://stacks-blockchain-gwrkhtq8y-hirosystems.vercel.app 🚀

Copy link

codecov bot commented Jul 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/event-stream/event-server.ts 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@rafaelcr rafaelcr changed the title fix: use burn block time in pre-nakamoto blocks fix: use burn_block_time in 2.x blocks and block_time after 3.x Jul 3, 2025
@rafaelcr rafaelcr marked this pull request as ready for review July 3, 2025 18:03
@rafaelcr rafaelcr requested a review from janniks July 3, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant