numpy23 np.number patch #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numpy/numpy#28254 When constructing a dtype from a class with a dtype attribute, that attribute must be a dtype-instance rather than a thing that can be parsed as a dtype instance. hist.datatype now returns float instead of np.number as datatype.
mbaak
force-pushed
the
numpy23_number_patch
branch
from
dc8cbf0 to
a9092e4
Compare
added 2 commits
August 25, 2025 15:03
TODO: histogrammar-scala does not yet support spark4.
mbaak
force-pushed
the
numpy23_number_patch
branch
from
a9092e4 to
e7c4ac0
Compare
sbrugman
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix compatibility with numpy v2.3 due to numpy datatype changes.
In numpy 2.3, converting np.number to a dtype no longer allowed.
numpy/numpy#28254
When constructing a dtype from a class with a dtype attribute, that attribute must be a dtype-instance rather than a thing that can be parsed as a dtype instance.
hist.datatype now returns float instead of np.number as datatype.