Skip to content

Allow for setup in existing directories. #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Allow for setup in existing directories. #827

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2368ae3
Allow for setup in existing directories.
Paul-Ferrell Mar 26, 2025
8229689
Update config.py
Paul-Ferrell Mar 27, 2025
3a28f1d
Update config.py
Paul-Ferrell Mar 27, 2025
432fd33
Merge branch 'develop' into config-dir-exists
hwikle-lanl May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lib/pavilion/commands/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,9 +203,8 @@ def create_config_dir(self, pav_cfg: config.PavConfig, path: Path,
raise ConfigCmdError("Given label '{}' already exists in the pav config."
.format(label))

# This should fail if it already exists.
try:
path.mkdir()
path.mkdir(parents=True, exist_ok=True)
except OSError as err:
raise ConfigCmdError("Could not create specified directory", err)

Expand Down Expand Up @@ -247,7 +246,7 @@ def create_config_dir(self, pav_cfg: config.PavConfig, path: Path,
for subdir in ('hosts', 'modes', 'platforms', 'plugins', 'collections', 'suites'):
subdir = path/subdir
try:
subdir.mkdir()
subdir.mkdir(exist_ok=True)
except OSError as err:
shutil.rmtree(path)
raise ConfigCmdError("Could not make config subdir '{}'".format(subdir), err)
Expand Down
Loading