More robust handling of samples that fail to filter

[keskitalo]

When filter flags prevent a template from being applied, flag all affected samples so they are not projected onto a map.

This is relevant when filters are subject to a processing mask that is not applied in map projection. Certain subscans may be entirely covered by the processing mask and escape subscan filtering. Unfiltered samples are subject to large uncertainties and should not be projected.

[Copilot]

Pull Request Overview

The PR enhances the robustness of sample filtering by flagging any samples that fail filter cuts so they aren’t projected onto maps.

• Updated SparseTemplates.mask to track failed slices alongside masked templates.
• Added checks in _exec to ensure filter flags overlap expected masks and to flag failed samples during execution.
• Improved handling in _build_template_covariance to treat infinite condition numbers as failures.

Comments suppressed due to low confidence (1)

src/toast/ops/filterbin.py:95

• Update the mask docstring to indicate it now returns a (masked, failed) tuple instead of a single SparseTemplates object.

        """Return a new SparseTemplates instance that complies with the

[Copilot]

This string isn’t an f-string, so the placeholders won’t be formatted. Change to msg += f"{self.filter_flag_mask} & {self.shared_flag_mask} = 0".

Suggested change

	msg += "{self.filter_flag_mask} & {self.shared_flag_mask} = 0"
	raise RuntimeError(msg)
	if self.filter_flag_mask & self.binning.det_flag_mask == 0:
	msg = f"Filter flag mask does not overlap with det bin mask: "
	msg += "{self.filter_flag_mask} & {self.binning.det_flag_mask} = 0"
	raise RuntimeError(msg)
	if self.filter_flag_mask & self.binning.shared_flag_mask == 0:
	msg = f"Filter flag mask does not overlap with shared bin mask: "
	msg += "{self.filter_flag_mask} & {self.binning.shared_flag_mask} = 0"
	msg += f"{self.filter_flag_mask} & {self.shared_flag_mask} = 0"
	raise RuntimeError(msg)
	if self.filter_flag_mask & self.binning.det_flag_mask == 0:
	msg = f"Filter flag mask does not overlap with det bin mask: "
	msg += f"{self.filter_flag_mask} & {self.binning.det_flag_mask} = 0"
	raise RuntimeError(msg)
	if self.filter_flag_mask & self.binning.shared_flag_mask == 0:
	msg = f"Filter flag mask does not overlap with shared bin mask: "
	msg += f"{self.filter_flag_mask} & {self.binning.shared_flag_mask} = 0"

[Copilot]

This string isn’t an f-string, so the placeholders won’t be formatted. Change to msg += f"{self.filter_flag_mask} & {self.binning.det_flag_mask} = 0".

Suggested change

	msg += "{self.filter_flag_mask} & {self.det_flag_mask} = 0"
	raise RuntimeError(msg)
	if self.filter_flag_mask & self.shared_flag_mask == 0:
	msg = f"Filter flag mask does not overlap with shared mask: "
	msg += "{self.filter_flag_mask} & {self.shared_flag_mask} = 0"
	raise RuntimeError(msg)
	if self.filter_flag_mask & self.binning.det_flag_mask == 0:
	msg = f"Filter flag mask does not overlap with det bin mask: "
	msg += "{self.filter_flag_mask} & {self.binning.det_flag_mask} = 0"
	raise RuntimeError(msg)
	if self.filter_flag_mask & self.binning.shared_flag_mask == 0:
	msg = f"Filter flag mask does not overlap with shared bin mask: "
	msg += "{self.filter_flag_mask} & {self.binning.shared_flag_mask} = 0"
	msg += f"{self.filter_flag_mask} & {self.det_flag_mask} = 0"
	raise RuntimeError(msg)
	if self.filter_flag_mask & self.shared_flag_mask == 0:
	msg = f"Filter flag mask does not overlap with shared mask: "
	msg += f"{self.filter_flag_mask} & {self.shared_flag_mask} = 0"
	raise RuntimeError(msg)
	if self.filter_flag_mask & self.binning.det_flag_mask == 0:
	msg = f"Filter flag mask does not overlap with det bin mask: "
	msg += f"{self.filter_flag_mask} & {self.binning.det_flag_mask} = 0"
	raise RuntimeError(msg)
	if self.filter_flag_mask & self.binning.shared_flag_mask == 0:
	msg = f"Filter flag mask does not overlap with shared bin mask: "
	msg += f"{self.filter_flag_mask} & {self.binning.shared_flag_mask} = 0"

[Copilot]

This string isn’t an f-string, so the placeholders won’t be formatted. Change to msg += f"{self.filter_flag_mask} & {self.binning.shared_flag_mask} = 0".

Suggested change

	msg += "{self.filter_flag_mask} & {self.det_flag_mask} = 0"
	raise RuntimeError(msg)
	if self.filter_flag_mask & self.shared_flag_mask == 0:
	msg = f"Filter flag mask does not overlap with shared mask: "
	msg += "{self.filter_flag_mask} & {self.shared_flag_mask} = 0"
	raise RuntimeError(msg)
	if self.filter_flag_mask & self.binning.det_flag_mask == 0:
	msg = f"Filter flag mask does not overlap with det bin mask: "
	msg += "{self.filter_flag_mask} & {self.binning.det_flag_mask} = 0"
	raise RuntimeError(msg)
	if self.filter_flag_mask & self.binning.shared_flag_mask == 0:
	msg = f"Filter flag mask does not overlap with shared bin mask: "
	msg += "{self.filter_flag_mask} & {self.binning.shared_flag_mask} = 0"
	msg += f"{self.filter_flag_mask} & {self.det_flag_mask} = 0"
	raise RuntimeError(msg)
	if self.filter_flag_mask & self.shared_flag_mask == 0:
	msg = f"Filter flag mask does not overlap with shared mask: "
	msg += f"{self.filter_flag_mask} & {self.shared_flag_mask} = 0"
	raise RuntimeError(msg)
	if self.filter_flag_mask & self.binning.det_flag_mask == 0:
	msg = f"Filter flag mask does not overlap with det bin mask: "
	msg += f"{self.filter_flag_mask} & {self.binning.det_flag_mask} = 0"
	raise RuntimeError(msg)
	if self.filter_flag_mask & self.binning.shared_flag_mask == 0:
	msg = f"Filter flag mask does not overlap with shared bin mask: "
	msg += f"{self.filter_flag_mask} & {self.binning.shared_flag_mask} = 0"