-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Mirror Origin header back in CORS response #760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@thornjad can you approve the workflow? |
"First-time contributors need a maintainer to approve running workflows." I'm dying to know if the tests pass :) |
For some reason GH isn't giving me the option to approve, could you maybe try merging master again? |
Here's what I did, but it seemed to already be up to date?:
On the matthias-ccri/http-server repo it's showing: Is the issue still there? |
Can this be merged? |
@thornjad is there a reason to not merge this? |
@thornjad This MR has been ready to merge for 9 months. |
This PR has been open for 553 days (or 18 months). @thornjad is there hesitation to this change or is there an issue with the PR? |
@BigBlueHat is there any maintainer still interested in this package? |
Use
corser
'sorigins
option to handle theaccess-control-allow-origin
header. Passing a true function will makecorser
mirror the Origin header like we want.I was not able to run the tests because my port
8080
is not available. I tried to make the tests configurable but I couldn't get thecors.test.js
server to use the right port with thehttpServer.listen()
calls. Hopefully the tests pass, but if they don't, I'll need some help debugging/rewriting the tests.Relevant issues
Resolves #729
Contributor checklist
--help
outputmaster
branchMaintainer checklist