Skip to content

[TRANSLATION] translated to fr communication, unit0 unit1 #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

knoel99
Copy link

@knoel99 knoel99 commented Feb 16, 2025

translated to fr communication, unit0 unit1

@knoel99 knoel99 mentioned this pull request Feb 17, 2025
3 tasks
@burtenshaw burtenshaw changed the title translated to fr communication, unit0 unit1 [TRANSLATION] translated to fr communication, unit0 unit1 Feb 18, 2025
@burtenshaw
Copy link
Collaborator

burtenshaw commented Feb 18, 2025

Thanks for the translation @knoel99 !

I will look for a french speaking reviewer and assign them to this PR.

@burtenshaw burtenshaw self-assigned this Feb 18, 2025
@lbourdois
Copy link

lbourdois commented Mar 9, 2025

Bonjour @knoel99 & @burtenshaw ! 🤗

I had a little time so I reviewed the "communication" and "unit0" parts.
Overall, it seems to me to be of good quality. The remarks mainly concern the fact that words remaining in English should be italicized, that acronyms don't take an “s” at the end in French, that in the meantime the “introduction” page for unit 0 has been updated and there's a layout problem for the discord101.mdx file.

I don't know when I'll be able to review Unit 1.
Concerning this one, I'd like to make sure that there haven't been any new changes in the space of 3 weeks + spread the remarks already made for unit 0 (i.e. the italicized English words and acronyms).

@knoel99
Copy link
Author

knoel99 commented Mar 10, 2025

@lbourdois thanks for your review, Then here is the TODO list:

  • italicized English words and acronyms
  • layout problem for the discord101.mdx file
  • Wait until april for the orignal english version to be stable and then resubmit PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants