Address deprecated ModelCardCallback from sentence_transformers #603
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a minor issue related to the deprecation of
sentence_transformers.model_card.ModelCardCallback
. This has since been changed tosentence_transformers.model_card.SentenceTransformerModelCardCallback
and the PR will catch either object type.I initially encounted a bug when I had
setfit==1.1.1
withsentence-transformers==4.1.0
(which resulted from an "unversioned" mamba-based build). Prior to #595 (as is the case for v1.1.1), there was an instance ofsentence_transformers.model_card.SentenceTransformerModelCardCallback
which was added by theadd_model_card_callback
method in thesentence_transformers.SentenceTransformerTrainer
class. Since the object type did not matchsentence_transformers.model_card.ModelCardCallback
(aliased asSTModelCardCallback
insetfit/trainer.py
), the callback was not removed and a call to thesetfit.Trainer
constructor resulted in this:Note that this is no longer an issue with
setfit==1.1.2
, yet this PR addresses the potential where either the current or deprecated callback makes its way intosetfit.trainer.BCSentenceTransformersTrainer