Skip to content

Add acquireLock, releaseLock. Fix metadata for multiple queues #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 25, 2025

Conversation

adam-fowler
Copy link
Member

  • Moved metadata setup to separate migration.
  • Renamed metadata table to swift_jobs.metadata

Copy link

codecov bot commented Jun 19, 2025

Codecov Report

Attention: Patch coverage is 97.43590% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.02%. Comparing base (489e671) to head (dc9d6d6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...stgres/Migrations/CreateJobMetadataMigration.swift 95.83% 1 Missing ⚠️
Sources/JobsPostgres/PostgresJobsQueue.swift 98.14% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   90.56%   91.02%   +0.45%     
==========================================
  Files           7        8       +1     
  Lines         530      568      +38     
==========================================
+ Hits          480      517      +37     
- Misses         50       51       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@thoven87 thoven87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. It's very flexible as one can have one schedule per queue. Usually, we just need one

@adam-fowler adam-fowler merged commit bd77418 into main Jun 25, 2025
12 of 14 checks passed
@adam-fowler adam-fowler deleted the lock-schedule branch June 25, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants