Skip to content

Move tokio/net feature to client to make TokioIo can used in wasm #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 22, 2025

Conversation

tiannian
Copy link
Contributor

@tiannian tiannian commented Jul 19, 2025

I was trying to port an http service using hyper-util to cloudflare worker but meet a dependency issue with mio. It caused by TokioIo need tokio feature, but this feature enable tokio/net. However, this was not necessary when using TokioIo alone, so I thought I could move this feature to the client.

Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is great!

Could you revert most of the formatting changes? (The ones for client and client-legacy are fine)

@tiannian
Copy link
Contributor Author

Hi @seanmonstar , I remove my local formatter effect. Just have some changes of this PR.

Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@seanmonstar seanmonstar merged commit 0d4ca3f into hyperium:master Jul 22, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants