Event Handler added to legacy Client. #234
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce PoolEvent and EventHandler for pool notifications - Notify on connection creation, closure, error, and timeout - Update Pool and PoolInner to support event handler - Notify on idle connection cleanup and connection drop events - Add scopeguard dependency for connection error handling
|
Thanks for the PR! I don't plan to make many changes to the legacy client, all work is going towards a newer design that will allow you to better customize the different layers of the pool. See hyperium/hyper#3849 for more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request introduces an Event Handler to the legacy client, an extension currently used in the Orion proxy.
The event handler, when enabled, allows the application to receive notifications about specific events occurring in the connection pool — such as the creation of a new connection, the closing of an idle connection, and more.
Specifically, this MR: