-
Notifications
You must be signed in to change notification settings - Fork 141
Enforce release builds for benchmarks and simplify command interface #741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot finished work on behalf of
jsturtevant
July 29, 2025 23:30
This seems like a much more sane approach than the previous iteration.... |
ludfjig
requested changes
Jul 29, 2025
Copilot finished work on behalf of
ludfjig
July 29, 2025 23:48
syntactically
previously requested changes
Jul 30, 2025
Copilot finished work on behalf of
syntactically
July 30, 2025 10:28
ludfjig
reviewed
Jul 30, 2025
ludfjig
approved these changes
Jul 30, 2025
21560f8
to
3185a0e
Compare
Signed-off-by: Simon Davies <[email protected]>
Co-authored-by: jsturtevant <[email protected]> Signed-off-by: Simon Davies <[email protected]>
…g symbols Co-authored-by: ludfjig <[email protected]> Signed-off-by: Simon Davies <[email protected]>
- Remove target parameter from bench and bench-ci commands since they only accept release builds - Update GitHub workflows to remove target parameter usage - Simplify command signatures based on @syntactically's feedback Co-authored-by: syntactically <[email protected]> Signed-off-by: Simon Davies <[email protected]>
…or profiling Co-authored-by: ludfjig <[email protected]> Signed-off-by: Simon Davies <[email protected]>
3185a0e
to
f570c1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that benchmarks run with release builds by default for meaningful performance measurements, while simplifying the command interface and supporting debug builds for profiling purposes.
Changes Made
Justfile Updates:
target
parameter frombench
andbench-ci
commands since they only accept release buildsjust bench [features]
andjust bench-ci baseline [features]
--profile=release
for consistent performance measurementsGitHub Workflows Updates:
Benchmarks.yml
anddep_rust.yml
to use simplified command signaturesBenchmark Code Changes:
Documentation:
docs/benchmarking-hyperlight.md
to clarify thatjust bench
uses release builds by defaultcargo bench
directly for profiling with debug symbolsBehavior
The changes maintain the same core behavior while providing a cleaner interface:
just bench
consistently uses release profile for meaningful resultscargo bench
directlyExamples
Backward Compatibility
All existing workflows continue to work without modification. The changes are purely simplifications that remove unnecessary complexity while preserving all functionality and adding profiling flexibility.
Fixes #638.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.