Testable process termination #48
Open
+147
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfnt
force-pushed
the
nfnt/test-process-termination
branch
from
afa585a to
550562b
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
crates/worker/src/driver/process.rs
Outdated
| sleep(Duration::from_secs(1)).await; | ||
|
|
||
| token.cancel(); | ||
| process.await.unwrap(); |
There was a problem hiding this comment.
Wonder whether we should wrap this in a timeout as this shouldn't hang
Moves process handling of the executor into a separate function. This allows to have tests for process termination.
nfnt
force-pushed
the
nfnt/test-process-termination
branch
from
550562b to
996b440
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves process handling of the executor into a separate function. This
allows to have tests for process termination.