-
Notifications
You must be signed in to change notification settings - Fork 0
feat(network): multi-codec req/resp + health check #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e7210d3
to
70e18cc
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
7b6c953
to
6bdc4fc
Compare
2fc4453
to
32660ae
Compare
This change generalizes our request/response plumbing to support multiple codecs and introduces a dedicated health codec (protocol). The network layer now exposes typed (codec) helpers to register handlers and make requests. A new health codec (`/hypha-health/0.0.1`) reports health/readiness. Gateway and worker register lightweight handlers that answer health requests once they meet their readiness criteria. All binaries feauture a `probe` subcommand that dials a target, performs a health request, and exits non-zero on failure/timeout, making it suitable for startup and liveness checks. Co-Authored-By: ChatGPT <[email protected]>
32660ae
to
78ea4c5
Compare
@nfnt i've combined the traits into one but still needed disambiguating some of the calls. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The implementation for the probe
subcommand is repeated among all binaries, maybe we should move the code for that to a separate library as a follow-up.
@nfnt yeah there are a few bits that are basically the same for all binaries and we should move them into a shared mod but I didn't go for it as I feel that it needs a little thought on how to best do that. |
This change generalizes our request/response plumbing to support multiple codecs and introduces a dedicated health codec (protocol). The network layer now exposes typed (codec) helpers to register handlers and make requests.
A new health codec (
/hypha-health/0.0.1
) reports health/readiness. Gateway and worker register lightweight handlers that answer health requests once they meet their readiness criteria. All binaries feauture aprobe
subcommand that dials a target, performs a health request, and exits non-zero on failure/timeout, making it suitable for startup and liveness checks.