Skip to content

Conversation

vidarl
Copy link
Contributor

@vidarl vidarl commented Mar 31, 2025

🎫 Issue IBX-8054

Related PRs:

Description:

Make an extension point for doing cleanup during delete operation.
For instance, field types may need to clean up data in ezcontentobject_attribute table for related content

For QA:

Documentation:

@vidarl vidarl changed the base branch from main to 4.6 March 31, 2025 10:22
@mnocon mnocon added the Doc needed The changes require some documentation label Apr 1, 2025
Copy link

@adamwojs adamwojs changed the title IBX-8054 Add extension point for doing cleanup during delete operation IBX-8054: Add extension point for doing cleanup during delete operation Apr 27, 2025
@adamwojs
Copy link
Member

@vidarl How this will affect performance ?

@vidarl
Copy link
Contributor Author

vidarl commented May 15, 2025

@vidarl How this will affect performance ?

The use of !tagged_iterator is dealt with at compile time, so shouldn't impact performance much.

But it is needed to loop over the handlers, indeed. Calling a method for each handler will cause a small overhead, but overall performance will mostly depend on what each handler actually needs to do.
But in regards to performance, I see no fundamental different between this approach and our trash events. A benefit here is that you can potentially do things faster as you are on in the persistence layer, not on Content layer.

That said, I am fine with removing the postDeleteContent(). I have no eminent use for it. I just added it as we have before and after events

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Doc needed The changes require some documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants