Skip to content

IBX-10159: Corrected generate dfs_database_url parameter for Ibexa Cloud #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: 4.6
Choose a base branch
from
Open

IBX-10159: Corrected generate dfs_database_url parameter for Ibexa Cloud #595

wants to merge 3 commits into from

Conversation

mateuszdebinski
Copy link
Contributor

🎫 Issue IBX-10159

Description:

Improved building of the dfs_database_url parameter. Previously it generated schema://user:password:port@host, now it generates schema://user:password@host:port

@mateuszdebinski mateuszdebinski requested a review from a team June 13, 2025 09:18
@mateuszdebinski mateuszdebinski self-assigned this Jun 13, 2025
@mateuszdebinski mateuszdebinski added Bug Something isn't working Ready for review labels Jun 13, 2025
@ezrobot ezrobot requested review from adamwojs, mikadamczyk, Steveb-p, alongosz, ciastektk, ViniTou, barw4 and wiewiurdp and removed request for a team June 13, 2025 09:18
alongosz
alongosz reviewed Jun 13, 2025
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok, but please try adding coverage for that. I'd expect it in DI tests (from \Matthias\* namespace - there's already some coverage). Please let me know if you have trouble finding how to do it.

@mateuszdebinski mateuszdebinski force-pushed the IBX-10159-incorrectly-generated-url-database branch from 9203402 to fa5ad6f Compare June 13, 2025 11:27
@mateuszdebinski mateuszdebinski requested a review from alongosz June 13, 2025 11:37
@mateuszdebinski mateuszdebinski force-pushed the IBX-10159-incorrectly-generated-url-database branch from 2e7298a to 4b7a325 Compare June 13, 2025 12:00
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alongosz alongosz alongosz approved these changes

@wiewiurdp wiewiurdp wiewiurdp approved these changes

@konradoboza konradoboza konradoboza approved these changes

@adamwojs adamwojs Awaiting requested review from adamwojs

@mikadamczyk mikadamczyk Awaiting requested review from mikadamczyk

@Steveb-p Steveb-p Awaiting requested review from Steveb-p

@ciastektk ciastektk Awaiting requested review from ciastektk

@ViniTou ViniTou Awaiting requested review from ViniTou

@barw4 barw4 Awaiting requested review from barw4

Assignees

@mikadamczyk mikadamczyk

@alongosz alongosz

@tischsoic tischsoic

@mateuszdebinski mateuszdebinski

Labels
Bug Something isn't working Ready for QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mateuszdebinski @adamwojs @alongosz @ViniTou @wiewiurdp @konradoboza @mikadamczyk @tischsoic