IBX-9727: Fixed strict types of Core Imagine integration layer #619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
requested review from
adamwojs,
mikadamczyk,
Steveb-p,
ciastektk,
ViniTou,
barw4,
wiewiurdp,
konradoboza and
tbialcz
alongosz
force-pushed
the
ibx-9727-strict-types-io
branch
from
203acad to
193bee5
Compare
alongosz
force-pushed
the
ibx-9727-strict-types-core-imagine
branch
from
7aa5041 to
dd6f888
Compare
adamwojs
force-pushed
the
ibx-9727-strict-types-io
branch
from
193bee5 to
72a596b
Compare
alongosz
force-pushed
the
ibx-9727-strict-types-io
branch
from
72a596b to
c824970
Compare
alongosz
force-pushed
the
ibx-9727-strict-types-core-imagine
branch
from
dd6f888 to
5a1342f
Compare
|
adamwojs
approved these changes
Aug 11, 2025
Comment on lines
+299
to
+302
| 'value' => new ImageValue([ | ||
| 'id' => 'images/6/8/4/0/486-10-eng-GB/photo.jpg', | ||
| ]), | ||
| ]); |
There was a problem hiding this comment.
Something is wrong with indentation here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
Related PRs:
Description:
Follow up to #613. IO layer touches
\Ibexa\Bundle\Core\Imaginenamespace which contains Imagick/Gmagick image manipulation integration.Contracts fixed:
\Ibexa\Contracts\Core\Variation\VariationHandler\Ibexa\Core\FieldType\Image\AliasCleanerInterface(internal)Outside of the namespace, fixed:
\Ibexa\Core\FieldType\Image\NullAliasCleaner\Ibexa\Core\MVC\Symfony\Templating\Twig\Extension\ImageExtensionBC breaks:
\Ibexa\Contracts\Core\Variation\VariationHandler::getVariationnow throws uniformly\Ibexa\Contracts\Core\Repository\Exceptions\InvalidArgumentExceptioninstead of PHP's nativeInvalidArgumentException. Some implementations already threw the Repository one, but the main implementation threw the PHP's native one. It makes more sense for it to be the Repository exception. However, as can be inferred from the diff, Twig functions:ibexa_image_aliasandibexa_content_field_identifier_image_assetwere affected.For QA:
Scope: image variation generation.
Regression tests:
Documentation:
Probably a note about the breaking change.