Skip to content

[minor] shorten and standardize s3 bucket access point name #1739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

faangbait
Copy link
Contributor

Issue

Access point names have a character limit, and if we're passing a fairly complex bucket name to the role, the read-only access point will be created, whereas the read-write access point will fail.

Line 88 of this file creates a read-only access point with the name {{ aws_bucket_name }}-ro-access-point.

Best practice for the read-write version of this bucket's access point is {{ aws_bucket_name }}-rw-access-point.

Description

Shortens and standardizes the read-write access point name.

Test Results

No tests. Simple change.


⚠️ Notes for Reviewers

  • Ensure you have understood the PR guidelines in the Playbook before proceeding with a review.
  • Ensure all sections in the PR template are appropriately completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant