-
Notifications
You must be signed in to change notification settings - Fork 97
[patch] Add support for Kafka 0.46 that drops Zookeeper #1788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a migration path with this change?
This reverts commit b2262ae.
@whitfiea I just added a migrate.yml and updated upgrade.yml The idea is to run migrate when ZooKeeper is detected during an upgrade, then follow on with the upgrade. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the changes it only seems to do the migrate when the provider is strimzi. If the provider is redhat then no migrate happens even though it is the same version installed. Shouldn't the migrate happen for both redhat and strimzi?
Also how is the 0.46 version defined?
{% if kafka_operator_name == "strimzi-kafka-operator" %} | ||
channel: strimzi-0.45.x | ||
{% else %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was this change made?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also how is the 0.46 version defined?
The default channel would be the stable channel and automatic updates. This is how we ended up going to 0.46.x in the first place
@Aymen-Ben-S could you comment on the red hat provider vs strimzi?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the code is shared between strimzi/redhat. The defect was originally reported in Strimzi, I didn't anticipate Redhat to also be affected. The Redhat migration does seem similar but still needs to be tested.
Issue
[MASCORE-6942] & [MASCORE-7312]
Description
Kafka dropped support of ZooKeeper, the changes update Small and Large templates to not use ZooKeeper anymore and switch to KRaft instead.
The changes also remove the temporary version hardcoding that was needed to restore FVT.
Test Results
Tested in Tech Foundation US cluster with v0.45 and v0.46. The latter version where the support for Zookeeped was dropped.