Skip to content

[patch] Add support for Kafka 0.46 that drops Zookeeper #1788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

Aymen-Ben-S
Copy link
Contributor

@Aymen-Ben-S Aymen-Ben-S commented Jun 2, 2025

Issue

[MASCORE-6942] & [MASCORE-7312]

Description

Kafka dropped support of ZooKeeper, the changes update Small and Large templates to not use ZooKeeper anymore and switch to KRaft instead.

The changes also remove the temporary version hardcoding that was needed to restore FVT.

Test Results

Tested in Tech Foundation US cluster with v0.45 and v0.46. The latter version where the support for Zookeeped was dropped.


⚠️ Notes for Reviewers

  • Ensure you have understood the PR guidelines in the Playbook before proceeding with a review.
  • Ensure all sections in the PR template are appropriately completed.

Copy link
Member

@whitfiea whitfiea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a migration path with this change?

@Aymen-Ben-S Aymen-Ben-S changed the title Kafka46 [patch] Add support for Kafka 0.46 that drops Zookeeper Jun 15, 2025
@Aymen-Ben-S
Copy link
Contributor Author

Aymen-Ben-S commented Jun 19, 2025

Is there a migration path with this change?

@whitfiea I just added a migrate.yml and updated upgrade.yml

The idea is to run migrate when ZooKeeper is detected during an upgrade, then follow on with the upgrade.

@Aymen-Ben-S Aymen-Ben-S requested a review from whitfiea June 19, 2025 20:35
Copy link
Member

@whitfiea whitfiea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the changes it only seems to do the migrate when the provider is strimzi. If the provider is redhat then no migrate happens even though it is the same version installed. Shouldn't the migrate happen for both redhat and strimzi?

Also how is the 0.46 version defined?

Comment on lines -22 to -24
{% if kafka_operator_name == "strimzi-kafka-operator" %}
channel: strimzi-0.45.x
{% else %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this change made?

Copy link
Contributor

@terenceq terenceq Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also how is the 0.46 version defined?

The default channel would be the stable channel and automatic updates. This is how we ended up going to 0.46.x in the first place

@Aymen-Ben-S could you comment on the red hat provider vs strimzi?

Copy link
Contributor Author

@Aymen-Ben-S Aymen-Ben-S Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the code is shared between strimzi/redhat. The defect was originally reported in Strimzi, I didn't anticipate Redhat to also be affected. The Redhat migration does seem similar but still needs to be tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants