-
Notifications
You must be signed in to change notification settings - Fork 97
[patch] add support for creating required repositories in aws ecr #1791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
terenceq
wants to merge
23
commits into
master
Choose a base branch
from
jira6432
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS Elastic Container Registry mirroring support
Provide support for mirroring images to AWS Elastic Container Registry (ECR) instances.
Description
In order to select ECR instances as the target registry for mirroring the capability to create the required ECR repositories must be provided. That is each image that will be mirrored needs to have the applicable ECR repository created in advance. For example the AWS cli command must be executed before an image can be uploaded:
aws ecr create-repository --repository-name {image_repo_name} --region {registry_ecr_aws_region}"
In order to use ECR as a target registry the following env variables should be set:
Before the applicable mirroring command is invoked the following should be satisfied:
aws ecr create-repository
may succeedTest Results
Successfully mirrored several catalogs/channels to various AWS ECR instances.