Skip to content

[patch] Add ability to set maxUnavailable for machine configs #1828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025
Merged

Conversation

IanBoden
Copy link
Contributor

Issue

Airgap testing is unreliable - no specific issue created

Description

Airgap tests were hitting two problems:

  1. fyre login sometimes failing the first time - the roks login task would retry so copied the settings from there
  2. setup frequently taking more than 2 hours and the pipeline timing it out - by updating worker nodes in parallel the time has roughly halved

Test Results

Tested by ongoing daily runs, will take time to see how much this improves stability but initial testing shows promise

⚠️ Notes for Reviewers

  • Ensure you have understood the PR guidelines in the Playbook before proceeding with a review.
  • Ensure all sections in the PR template are appropriately completed.

@IanBoden IanBoden marked this pull request as ready for review July 10, 2025 09:51
@IanBoden IanBoden changed the title Add ability to set maxUnavailable for machine configs [patch] Add ability to set maxUnavailable for machine configs Jul 14, 2025
Copy link
Contributor

@durera durera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea!

@durera durera added this pull request to the merge queue Jul 14, 2025
Merged via the queue into master with commit 1025b8b Jul 14, 2025
2 checks passed
@durera durera deleted the ibmax branch July 14, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants