Dealing with upper-case special search terms #1303
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, typing "System:adventuron" into the search bar provides results but just searches for the words 'system' and 'adventuron'. Typing "system:adventuron" correctly returns games in the adventuron system.
This update is intended to reduce the incoming data to lowercase. I've tested it in codespace and it seems to work. I had an earlier pull request that ended up making all text input lowercase. This update only changes words in search right before they're checked if they're a special term or not.
I was worried it might mess up non-standard characters, but it seems like we have trouble with non-standard characters anyway. For instance, searching for "年" doesn't bring up 年獸文字冒險遊戲 | The Beast, Nian: A Chinese Text Adventure.
This is my first pull request in a while (I took a github class for certification and want to see if it helped make this all make more sense), so feel free to let me know if this is the wrong way to do things.