Add QBMAX expansions #233
Open
Add QBMAX expansions #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This and #232 look just about identical. I think only one of them is needed? |
Just include |
inducer
reviewed
Jun 18, 2025
sumpy/expansion/local.py
Outdated
|
|
||
|
|
||
| # {{{ Asymline taylor | ||
| class AsymLineTaylorLocalExpansion(LocalExpansionBase): |
There was a problem hiding this comment.
Add documentation describing what this does.
sumpy/expansion/local.py
Outdated
|
|
||
|
|
||
| # {{{ Asymline taylor | ||
| class AsymLineTaylorLocalExpansion(LocalExpansionBase): |
sumpy/qbx.py
Outdated
There was a problem hiding this comment.
Parts of this look like it interferes with/duplicates/undoes #229. Could you clarify the relationship? We should have one PR per change; it's not great to gobble multiple changes into one.
There was a problem hiding this comment.
You’re right — the changes in qbx.py overlap with those in #229. I’ve removed them from this PR to avoid duplication.
ShawnL00
force-pushed
the
feature/asymline
branch
from
4a52f96 to
2764266
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also set CACHING_ENABLED = False in sumpy/tools.py. For different$\tau$ values, do we need to create separate cache files for the kernels?