Allow to reset the form after successful submit and sync the defaults afterwards #2412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a Fix to #2411.
After digging into issues and code i found the following comment from Jess Archer which describe the steps to reproduce, but for the vue form.
Which leads me to the form helper of vue and i found different behavior vue vs react.
The critical
setDefaults(data)inonSuccesswas introduce by #2236 to fix an issue with reactivity of the isDirty prop.Solution:
To bring vue and react in sync an solve this bug, we have to move the
setDefaultsafter running theonSuccesshook, which bring the reset data and the defaults in sync.