Run all tests with SQL Mode #3746
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… due to seriliaziation errors - not misues of the underlying Store)
awildturtok
commented
Jun 3, 2025
| @@ -48,6 +49,6 @@ public SingleColumnSqlSelect qualify(final String qualifier) { | |||
|
|
|||
| @Override | |||
| public SqlSelect connectorAggregate() { | |||
| return new ExistsSqlSelect(DSL.max(select()).as(alias), alias); | |||
| return new ExistsSqlSelect(DSL.max(DSL.coalesce(select(), DSL.value(0))).as(alias), alias); | |||
There was a problem hiding this comment.
Macht nichts :(
There was a problem hiding this comment.
Was hattest du an der Stelle erwartet, was es tun sollte?
There was a problem hiding this comment.
Das Problem ist, dass der ExistsSelect entweder 1 oder null ist. Wir wollen aber 1 oder 0. Ich hatte gehofft dass so zu forcieren. Aber das gibt der Code glaube ich nicht her.
| @@ -19,24 +25,28 @@ public class SqlTestDataImporter implements TestDataImporter { | |||
|
|
|||
| private final CsvTableImporter csvTableImporter; | |||
|
|
|||
|
|
|||
| @Override | |||
| public void importQueryTestData(StandaloneSupport support, QueryTest test) throws Exception { | |||
There was a problem hiding this comment.
Ich glaube nicht, dass die noch großartig anders sind außer der AllIdsTabelle
…DataImporter and unifiying that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.