Skip to content

migrates to using a SlidingWindow based Histogram for tracking Execut… #3754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

migrates to using a SlidingWindow based Histogram for tracking Execut… #3754

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion backend/src/main/java/com/bakdata/conquery/metrics/ExecutionMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
import java.util.Collection;
import java.util.HashSet;
import java.util.Set;
import java.util.SortedMap;
import java.util.concurrent.TimeUnit;

import com.bakdata.conquery.apiv1.query.CQElement;
import com.bakdata.conquery.apiv1.query.QueryDescription;
Expand All @@ -23,6 +25,7 @@
import com.codahale.metrics.Histogram;
import com.codahale.metrics.MetricRegistry;
import com.codahale.metrics.SharedMetricRegistries;
import com.codahale.metrics.SlidingTimeWindowReservoir;
import lombok.Data;
import lombok.experimental.UtilityClass;

Expand Down Expand Up @@ -50,7 +53,15 @@ private static String nameWithGroupTag(String name, String group) {
}

public static Histogram getQueriesTimeHistogram(String group) {
return SharedMetricRegistries.getDefault().histogram(nameWithGroupTag(MetricRegistry.name(QUERIES, TIME), group));
MetricRegistry metricRegistry = SharedMetricRegistries.getDefault();
String name = nameWithGroupTag(MetricRegistry.name(QUERIES, TIME), group);

SortedMap<String, Histogram> histograms = metricRegistry.getHistograms();
if (histograms.containsKey(name)) {
return histograms.get(name);
}

return metricRegistry.register(name, new Histogram(new SlidingTimeWindowReservoir(1, TimeUnit.HOURS)));
}

public static Counter getQueryStateCounter(ExecutionState state, String group) {
Expand Down
Loading