Remove unused or replacable dependencies #3759
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thoniTUB
commented
Jul 1, 2025
| @@ -260,7 +263,7 @@ private void preprocessJobs(Collection<PreprocessingJob> jobs, int buckets, Conq | |||
| .mapToLong(PreprocessingJob::estimateTotalCsvSizeBytes) | |||
| .sum(); | |||
|
|
|||
| log.info("Required to preprocess {} in total", BinaryByteUnit.format(totalSize)); | |||
| log.info("Required to preprocess {} in total", FileUtils.byteCountToDisplaySize(totalSize)); | |||
There was a problem hiding this comment.
@awildturtok wäre für mich okay:
import com.jakewharton.byteunits.BinaryByteUnit
import io.dropwizard.util.DataSize
import org.apache.commons.io.FileUtils
def size = 12334556789L
println BinaryByteUnit.format(size)
println DataSize.bytes(size).toString()
println FileUtils.byteCountToDisplaySize(size)
// Prints
11,5 GiB
12334556789 bytes
11 GB
awildturtok
reviewed
Jul 1, 2025
| @@ -260,7 +263,7 @@ private void preprocessJobs(Collection<PreprocessingJob> jobs, int buckets, Conq | |||
| .mapToLong(PreprocessingJob::estimateTotalCsvSizeBytes) | |||
| .sum(); | |||
|
|
|||
| log.info("Required to preprocess {} in total", BinaryByteUnit.format(totalSize)); | |||
| log.info("Required to preprocess {} in total", FileUtils.byteCountToDisplaySize(totalSize)); | |||
backend/src/main/java/com/bakdata/conquery/util/io/ClassPathHandler.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.