Implements two stage Caching for ExecutionManager. Hard references, b… #3760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut timed. And untimed SoftReferences. This should help us fail earlier in congested scenarios, but also keep new results around for longer in contended situations.
awildturtok
force-pushed
the
feature/multistage-caches
branch
from
c3287fc to
8733cbf
Compare
thoniTUB
requested changes
Jul 2, 2025
backend/src/main/java/com/bakdata/conquery/models/config/QueryConfig.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/bakdata/conquery/models/query/ExecutionManager.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/bakdata/conquery/models/query/ExecutionManager.java
Outdated
Show resolved
Hide resolved
Comment on lines
34
to
38
| @JsonIgnore | ||
| @ValidationMethod(message = "SoftResultCache is required to be soft.") | ||
| public boolean isSoftSpecSoft() { | ||
| return softResultCacheSpec.contains("softValues"); | ||
| } |
There was a problem hiding this comment.
Wenn du Caffeine nutzt kannst du auch @ValidCaffeineSpec() nehmen
thoniTUB
reviewed
Jul 2, 2025
backend/src/main/java/com/bakdata/conquery/models/config/QueryConfig.java
Outdated
Show resolved
Hide resolved
…Config.java Co-authored-by: MT <[email protected]>
thoniTUB
approved these changes
Jul 9, 2025
|
Ich muss hier noch die Namen anpassen sehe ich gerade |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ut timed. And untimed SoftReferences. This should help us fail earlier in congested scenarios, but also keep new results around for longer in contended situations.