-
Notifications
You must be signed in to change notification settings - Fork 0
Update copy text #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update copy text #38
Conversation
WalkthroughThis update revises several user-facing messages and labels throughout the application. Text changes include rewording warnings, updating labels from "history" to "activity," and adding punctuation for clarity. No logic, control flow, or error handling is affected; only the displayed text and labels are modified. Changes
Poem
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/widget-react/src/pages/wallet/tabs/Home.tsx (1)
41-43
: Consider extracting hard-coded tab labels into a common i18n/label map
The literal string"Activity"
is now duplicated across multiple components ( Home, BridgeHistory, tx notification, etc.). Centralising user-facing copy (e.g. viasrc/i18n/en.json
or aUI_LABELS
constant) avoids drift in future copy updates and simplifies localisation.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
packages/widget-react/src/pages/bridge/BridgeFields.tsx
(1 hunks)packages/widget-react/src/pages/bridge/BridgeHistory.tsx
(2 hunks)packages/widget-react/src/pages/bridge/SlippageControl.tsx
(1 hunks)packages/widget-react/src/pages/bridge/data/tx.ts
(1 hunks)packages/widget-react/src/pages/wallet/tabs/Home.tsx
(1 hunks)packages/widget-react/src/pages/wallet/txs/send/SendFields.tsx
(1 hunks)
🔇 Additional comments (6)
packages/widget-react/src/pages/bridge/SlippageControl.tsx (1)
50-51
: Copy tweak looks good – punctuation added for consistency.packages/widget-react/src/pages/bridge/BridgeFields.tsx (1)
269-270
: Message update acknowledged – wording now matches the Send flow.packages/widget-react/src/pages/wallet/txs/send/SendFields.tsx (1)
96-101
: Copy consistency looks good – fee warning and memo info now align with Bridge flow wording & punctuation.packages/widget-react/src/pages/bridge/data/tx.ts (1)
168-172
: No broken link—/bridge/history
is the only registered route
A search through your TS/JS files shows that only/bridge/history
is defined (in Routes.tsx) and used (in BridgeForm.tsx and tx.ts). There is no/bridge/activity
route, so the link to/bridge/history
won’t break. The phrase “activity page” is purely a display label.Optional: For consistency, you may choose to rename the link text to “history page,” but functionally the code is correct.
packages/widget-react/src/pages/bridge/BridgeHistory.tsx (2)
27-27
: Copy update is clear and matches the new terminology
Changing the page title to “Bridge/Swap activity” aligns with the global rename effort and involves no functional impact.
41-41
: Empty-state copy updated consistently
The new message keeps the wording in sync with the title and other pages. No additional concerns.
https://linear.app/initia-labs/issue/PM-319/minor-copy-adjustments-2
Summary by CodeRabbit