Add VM lifecycle management to AAP configuration #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements playbook_cloudkit_create_vm.yml and playbook_cloudkit_delete_vm.yml to handle virtual machine creation and deletion operations. These playbooks integrate with the VM template system and provide proper resource management including namespace finalizers and locking mechanisms. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add create-vm and delete-vm job templates with vm-operations instance group - Configure vm-operations inventory and inventory source for VM management - Set up vm-operations-ig container group with kubernetes service account access 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Comment on lines
+49
to
+67
| - name: Acquire VM lock for deletion | ||
| kubernetes.core.k8s: | ||
| state: present | ||
| apply: true | ||
| server_side_apply: | ||
| field_manager: "{{ vm_order_holder_id }}" | ||
| definition: | ||
| apiVersion: coordination.k8s.io/v1 | ||
| kind: Lease | ||
| metadata: | ||
| name: "{{ vm_order_lock_name }}" | ||
| namespace: "{{ vm_target_namespace }}" | ||
| labels: | ||
| cloudkit.openshift.io/aap-job-id: "job-{{ awx_job_id | default('unknown') }}" | ||
| cloudkit.openshift.io/resource-type: "vm" | ||
| cloudkit.openshift.io/operation: "delete" | ||
| spec: | ||
| holderIdentity: "{{ vm_order_holder_id }}" | ||
|
|
There was a problem hiding this comment.
I don't think need the lock
There was a problem hiding this comment.
@adriengentil Actually we do need the lock. From my testing, if we don't grab a lock then 2 namespaces can be created. I'm not sure how this is possible but it happens. I am testing this fix now and will update the PR once I know it works. (Also, I believe the lock should be held in the CloudKit namespace...)
| description: "Publish templates inventory" | ||
| organization: "{{ aap_organization_name }}" | ||
| - name: "{{ aap_prefix }}-vm-operations" | ||
| description: "VM Operational Inventory - Dedicated BM Hypervisors" |
There was a problem hiding this comment.
"Dedicated BM Hypervisors" ?
|
no eda config as code? |
This was referenced Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR depends on #131
🤖 Generated with Claude Code