Add ocp_virt_vm template for OpenShift Virtualization VMs #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements playbook_cloudkit_create_vm.yml and playbook_cloudkit_delete_vm.yml to handle virtual machine creation and deletion operations. These playbooks integrate with the VM template system and provide proper resource management including namespace finalizers and locking mechanisms. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add create-vm and delete-vm job templates with vm-operations instance group - Configure vm-operations inventory and inventory source for VM management - Set up vm-operations-ig container group with kubernetes service account access 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- extract_vm_template_info: Extract and normalize template IDs and parameters from VM orders - vm_settings: Apply default settings and merge with user parameters, including cloud-init defaults - vm_working_namespace: Retrieve and validate working namespace for VM resources 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Added needed params
This template enables VM provisioning on OpenShift using the Virtualization operator. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
adriengentil
reviewed
Oct 2, 2025
| type: str | ||
| required: true | ||
| description: The namespace where VM resources will be created | ||
| template_parameters: |
There was a problem hiding this comment.
I think it was discussed in another closed PR, but I think this list must be cleaned up
adriengentil
reviewed
Oct 2, 2025
Comment on lines
+14
to
+24
| default_node_request: | ||
| - resourceClass: ocp_cluster | ||
| numberOfNodes: 1 | ||
|
|
||
| # This declares that for a VM built from this template, only the resource | ||
| # classes listed here may be used. For VMs, this represents different | ||
| # types of OpenShift clusters (standard, GPU-enabled, etc.) | ||
| allowed_resource_classes: | ||
| - ocp_cluster | ||
| - ocp_virt_enabled | ||
| - ocp_gpu_enabled |
There was a problem hiding this comment.
these parameters have no use for the moment, they can be removed
adriengentil
reviewed
Oct 2, 2025
| storage: "{{ vm_disk_size }}" | ||
| state: present | ||
|
|
||
| - name: Create DataVolumes for additional disks |
There was a problem hiding this comment.
let's remove the support for multiple disks, it may be added later if there is a need
|
I think the first template should focus on a very small subset of parameters to start on. Their might be added later if their is a need. |
|
@adriengentil Ok. No problem. I will work on those fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated with Claude Code