Skip to content

Allow documents to be loaded locally for Knowledge Injection #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow documents to be loaded locally for Knowledge Injection #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/instructlab/schema/v3/knowledge.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,28 +76,32 @@
"description": "The knowledge documents.",
"type": "object",
"required": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you have properly specified the oneOf choice here correctly in JSON schema. It is one of either repo+commit or folder.

"repo",
"commit",
"patterns"
],
"unevaluatedProperties": false,
"properties": {
"repo": {
"description": "The URL to a Git repository holding the knowledge documents.",
"type": "string",
"minLength": 1,
"examples": [
"https://github.com/instructlab/instructlab.git"
]
},
"commit": {
"description": "The commit in the Git repository containing the knowledge documents.",
"type": "string",
"minLength": 1,
"examples": [
"951999afdc59c46d325493568193b40bd5439c9e"
]
},
"folder": {
"description": "The absolute path to documents in the local server.",
"type": "string",
"minLength": 1,
"examples": [
"/home/user/docs/"
]
},
"patterns": {
"description": "An array of glob patterns of the knowledge documents in the Git repository.",
"type": "array",
Expand All @@ -124,4 +128,4 @@
]
}
}
}
}