Skip to content

[CLX-2537] Implement UI components #3190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2025

Conversation

tamaskozmer
Copy link
Contributor

@tamaskozmer tamaskozmer commented Aug 7, 2025

Test plan: Check the previews

refs: CLX-2537
affects: Student
release note: none

Checklist

  • Tested in light mode

@inst-danger
Copy link
Contributor

Parent Install Page

@inst-danger
Copy link
Contributor

Student Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

data class ProgramCourseCardState(
val courseName: String,
val status: CourseCardStatus,
val courseProgress: Double? = null,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the courseProgress attribute could be part the InProgress Status

import com.instructure.horizon.R

data class ProgramProgressState(
val courses: List<ProgramProgressItemState>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sequential index of the course is in the item's model, but I didn't find any sorting logic. I couldn't find any API documentation, but I think it would worth to ensure that the order of courses is always correct.

@tamaskozmer tamaskozmer merged commit c2d1358 into master Aug 14, 2025
4 checks passed
@tamaskozmer tamaskozmer deleted the CLX-2537-implement-ui-components branch August 14, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants