Explain potential for abuse #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dthaler
reviewed
Jul 26, 2024
Co-authored-by: Dave Thaler <[email protected]>
dthaler
approved these changes
Jul 26, 2024
tfpauly
reviewed
Jul 26, 2024
|
|
||
| While protocol features, extensions, and versions all have legitimate uses, they | ||
| can become a burden when used to excess. For example, the ability to send | ||
| protocol grease that a peer is required to ignore can be abused to cause it to |
There was a problem hiding this comment.
Maybe explain some examples of the abuse — not just the fact of ignoring one greased object, but having a flood of them that are all ignored, etc.
There was a problem hiding this comment.
Thought: There is a "cost" when the greasing creates state, even if only to ignore the greased value. (I can think of cases where seeing a new value needs the receiver to do work to ignore. )
|
We could also have some positive advice earlier to generators of great to say "don't grease too much" |
|
Discussion in the room was: split the text across the sections, which I'll do on this PR so its not ready to be merged yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22