-
Notifications
You must be signed in to change notification settings - Fork 45
Cross compile tools for ARM (aarch64) #394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add in zlib support for lspci
install. Happens on docker build on some hosts but not all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome. One issue with where to get the aarch64 binaries when building with the container.
Too bad turbostat is x86 only. It's really useful for telemetry. |
b5ffee6
to
952062d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like I said in the comment. This is very close. If I could make this one change myself I would do it and then merge, but I think you need to do it. Then, I can run my internal tests. I don't see any reason they would fail from these changes. Once passed, I can merge.
Thanks!
@@ -51,7 +51,7 @@ jobs: | |||
name: perfspect | |||
- name: run test | |||
run: | | |||
tar -xf perfspect* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So close! This issue is also preventing my internal tests from running. Instead of, or in addition to, this change...
It would work best if the ARM build was in a separate artifact. So, the upload perfspect step (line 22) needs to be modified to only include perfspect.tgz. And, add an additional step to upload the ARM build.
Cross compile supporting toolchain (where possible)
For perf, I bumped up the version to get a newer version of perf that supports Neoverse V2 cores
processwatch has ARM support, but we can't crosscompile right now as we need an ARM kernel to do the btf dump
e.g.
Did a basic perf test on a Neoverse V2 guest to validate perf: