Fix typo in __GNUC_PREREQ__ version check
#1086
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__GNUC_MINOR__ was missing a trailing underscore, which prevented __builtin_expect() from being used via __predict_false() in the error path of checked functions like __memcpy_chk(). __builtin_expect is defined from GCC 3 (2001) and Clang 2.2 (2008). Signed-off-by: Tiago de Paula <[email protected]>
jbdelcuv
approved these changes
Jul 14, 2025
|
@jbdelcuv Just so you know, I can't merge this as don't have write access to the repo. A maintainer must do it. |
alviroiskandar
approved these changes
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__GNUC_MINOR__was missing a trailing underscore, which prevented__builtin_expect()from being used via__predict_false()in the error path of checked functions like__memcpy_chk().__builtin_expectis defined from GCC 3 (2001) and Clang 2.2 (2008).