Skip to content

[SYCL] Kernel free function num args functionality #19517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 26 commits into
base: sycl
Choose a base branch
from
Open

[SYCL] Kernel free function num args functionality #19517

wants to merge 26 commits into from

Conversation

dklochkov-emb
Copy link
Contributor

@dklochkov-emb dklochkov-emb commented Jul 18, 2025 •
edited
Loading

This PR adds possibility to get kernel free function number of arguments according to docs
Tests were added according to test plan.

@dklochkov-emb dklochkov-emb self-assigned this Jul 18, 2025
@dklochkov-emb dklochkov-emb requested review from a team as code owners July 18, 2025 17:31
@dklochkov-emb dklochkov-emb mentioned this pull request Jul 18, 2025
Merged
steffenlarsen
steffenlarsen reviewed Jul 21, 2025
View reviewed changes
steffenlarsen
steffenlarsen approved these changes Jul 24, 2025
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confident that once my last few comments have been addressed, I am happy with this!

@dklochkov-emb
Copy link
Contributor Author

dklochkov-emb commented Jul 28, 2025 •
edited
Loading

@intel/dpcpp-cfe-reviewers @premanandrao @elizabethandrews @Fznamznon please, review it

premanandrao
premanandrao reviewed Jul 28, 2025
View reviewed changes
Copy link
Contributor

@premanandrao premanandrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor formatting comments, but otherwise, looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@AlexeySachkov AlexeySachkov Awaiting requested review from AlexeySachkov

@premanandrao premanandrao Awaiting requested review from premanandrao

At least 1 approving review is required to merge this pull request.

Assignees

@dklochkov-emb dklochkov-emb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dklochkov-emb @AlexeySachkov @premanandrao @steffenlarsen